Skip to content

8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earthling-amzn
Copy link
Contributor

@earthling-amzn earthling-amzn commented Jun 20, 2025

This is a low risk change that fixes an assertion failure with Shenandoah's generational mode and virtual threads. Only Shenandoah's generational mode is affected by this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8357550 needs maintainer approval

Issue

  • JDK-8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk24u.git pull/234/head:pull/234
$ git checkout pull/234

Update a local copy of the PR:
$ git checkout pull/234
$ git pull https://git.openjdk.org/jdk24u.git pull/234/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 234

View PR using the GUI difftool:
$ git pr show -t 234

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk24u/pull/234.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2025

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 17cf49746d0c289bdf779c974cdc84a3ab32ab4b 8357550: GenShen crashes during freeze: assert(!chunk->requires_barriers()) failed Jun 20, 2025
@openjdk
Copy link

openjdk bot commented Jun 20, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2025

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 20, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant