-
Notifications
You must be signed in to change notification settings - Fork 187
8425: Problem importing in Eclipse due to missing awatility 3rd party artefact #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8425: Problem importing in Eclipse due to missing awatility 3rd party artefact #668
Conversation
👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.
@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
@viragpurnam : Hmm, this is a test requirement, only needed by a test plugin. So it should not be shipped as part of the product. If it works like this it is fine, if not we have to look at some other mechanism. |
I think Virag just meant the target platform, where all third party dependencies are exported over a p2. |
Ok, I can try to include it |
The Jolokia test plugin requires awaitility
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668
$ git checkout pull/668
Update a local copy of the PR:
$ git checkout pull/668
$ git pull https://git.openjdk.org/jmc.git pull/668/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 668
View PR using the GUI difftool:
$ git pr show -t 668
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/668.diff
Using Webrev
Link to Webrev Comment