Skip to content

Conversation

skarsaune
Copy link
Contributor

@skarsaune skarsaune commented Jul 27, 2025

The Jolokia test plugin requires awaitility


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-8425: Problem importing in Eclipse due to missing awatility 3rd party artefact (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/668/head:pull/668
$ git checkout pull/668

Update a local copy of the PR:
$ git checkout pull/668
$ git pull https://git.openjdk.org/jmc.git pull/668/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 668

View PR using the GUI difftool:
$ git pr show -t 668

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/668.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2025

👋 Welcome back skarsaune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@skarsaune skarsaune changed the title JMC-8425: Ensure awaitlity is available as a 3rd party plugin JMC-8425: Problem importing in Eclipse due to missing awatility 3rd party artefact Jul 27, 2025
@openjdk openjdk bot changed the title JMC-8425: Problem importing in Eclipse due to missing awatility 3rd party artefact 8425: Problem importing in Eclipse due to missing awatility 3rd party artefact Jul 27, 2025
@skarsaune skarsaune marked this pull request as ready for review July 27, 2025 18:35
@openjdk openjdk bot added the rfr label Jul 27, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2025

Webrevs

Copy link
Contributor

@viragpurnam viragpurnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2025

@skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@skarsaune
Copy link
Contributor Author

Hi @skarsaune, this plugin needs to be added to all target platforms as well under local p2 repository.

@viragpurnam : Hmm, this is a test requirement, only needed by a test plugin. So it should not be shipped as part of the product. If it works like this it is fine, if not we have to look at some other mechanism.

@thegreystone
Copy link
Member

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

@skarsaune
Copy link
Contributor Author

I think Virag just meant the target platform, where all third party dependencies are exported over a p2.

Ok, I can try to include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants