Skip to content

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Sep 2, 2025

work in progress...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • CODETOOLS-7904072: Fail for arrays in JUnit assert[Not]Equals methods (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jtreg.git pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.org/jtreg.git pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jtreg/pull/284.diff

This commit introduces a patch for JUnit's AssertionUtils class to throw an exception when arrays are used in assert[Not]Equals methods
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@sormuras sormuras changed the title Codetools 7904072 fail assertequals with arrays 7904072: Fail for arrays in JUnit assert[Not]Equals methods Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant