Preview mode changes. #1597
Draft
Preview mode changes. #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back david-beaumont! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@david-beaumont this pull request can not be integrated into git checkout jdk_8352750_preview_mode
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
openjdk
bot
added
the
merge-conflict
david-beaumont
force-pushed
the
jdk_8352750_preview_mode
branch
from
50c4dac to
ece6a1a
Compare
* Adjusting tests and fixing loose ends from merge. * Serialization fix * squash everything latest
david-beaumont
force-pushed
the
jdk_8352750_preview_mode
branch
from
fe0bd75 to
ee3dbcf
Compare
openjdk
bot
removed
the
merge-conflict
* Fix test for new ModuleReference behaviour. * Make preview mode system property dependent in classloader. * Update benchmark for preview mode and new ImageReader methods.
openjdk
bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS NOT FOR CODE REVIEW - DO NOT REVIEW THIS
Rollup of all current preview mode work for Valhalla.
Because the work I've put into JDK mainline (as far back as July) is not yet integrated into Valhalla, this work cannot be considered for submission yet. However, I'm going to put it here for specific people to look at.
Because this is based off a baseline of the changes in mainline (manually patched in), it MUST be view in relation to #1596 to get the preview mode specific diffs.
david-beaumont/openjdk_valhalla@jdk_8352750_baseline...david-beaumont:openjdk_valhalla:jdk_8352750_preview_mode
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1597/head:pull/1597$ git checkout pull/1597Update a local copy of the PR:
$ git checkout pull/1597$ git pull https://git.openjdk.org/valhalla.git pull/1597/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1597View PR using the GUI difftool:
$ git pr show -t 1597Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1597.diff