-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: range reserveOrdinals for AdvancedStatefulSet #1873
feature: range reserveOrdinals for AdvancedStatefulSet #1873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1873 +/- ##
==========================================
+ Coverage 42.45% 42.54% +0.08%
==========================================
Files 312 313 +1
Lines 31328 31364 +36
==========================================
+ Hits 13301 13343 +42
+ Misses 16657 16652 -5
+ Partials 1370 1369 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: AiRanthem <[email protected]>
Signed-off-by: AiRanthem <[email protected]>
Signed-off-by: AiRanthem <[email protected]>
Signed-off-by: AiRanthem <[email protected]>
Signed-off-by: AiRanthem <[email protected]>
e60e0a5
to
58ffbc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Ⅰ. Describe what this PR does
support range value like
1-5
to assign a lot of reserveOrdinals in AdvancedStatefulSet, which looks like:the example is the same as:
so you don't have to write a very long reserveOrdinals list.
Ⅱ. Does this pull request fix one issue?
fixes #1846
Ⅲ. Describe how to verify it
use the example above
Ⅳ. Special notes for reviews