add concurrency control when pull image in daemon #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1918 +/- ##
==========================================
- Coverage 42.57% 42.54% -0.04%
==========================================
Files 313 313
Lines 31364 31387 +23
==========================================
Hits 13354 13354
- Misses 16642 16665 +23
Partials 1368 1368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ABNER-1
force-pushed
the
opt-imagepulljob
branch
from
1ff125c to
c4d8fcf
Compare
Signed-off-by: Abner-1 <[email protected]>
ABNER-1
force-pushed
the
opt-imagepulljob
branch
from
c4d8fcf to
ec217dd
Compare
zmberg
reviewed
Feb 24, 2025
| @@ -94,7 +95,7 @@ func NewController(opts daemonoptions.Options, secretManager daemonutil.SecretMa | |||
| }, | |||
| }) | |||
|
|
|||
| puller, err := newRealPuller(opts.RuntimeFactory.GetImageService(), secretManager, recorder) | |||
| puller, err := newRealPuller(opts.RuntimeFactory.GetImageService(), secretManager, recorder, opts.MaxWorkersForPullImages) | |||
There was a problem hiding this comment.
The stats for the newStatus field in the sync function, do we need to add waiting filed as well. also, add some e2e or UT as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
add concurrency control when pull image in daemon
Ⅱ. Does this pull request fix one issue?
fixes #1681
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews