Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the bug #1932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RohanMishra315
Copy link

#1916

Modify the webhook options to explicitly set TLS configuration:

  1. MinVersion: Ensures only TLS 1.2 and above are allowed.
  2. CipherSuites: Removes insecure ciphers like CBC-based ones and RSA key exchange.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.55%. Comparing base (6d2f3f5) to head (8ce55e3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1932      +/-   ##
==========================================
- Coverage   42.57%   42.55%   -0.03%     
==========================================
  Files         313      313              
  Lines       31364    31364              
==========================================
- Hits        13354    13346       -8     
- Misses      16642    16649       +7     
- Partials     1368     1369       +1     
Flag Coverage Δ
unittests 42.55% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohanMishra315
Copy link
Author

@furykerry made the pr , pls look at it and suggest the necessary changes

@zmberg
Copy link
Member

zmberg commented Feb 24, 2025

@furykerry @RohanMishra315
Starting with kruise version 1.8, since we switched kruise golang version to 1.22, tls 1.2 is already the default behaviour.

So, if this pr is only applied to >- kruise 1.8 I don't think it's necessary. If, however, it is intended to take effect for kruise < 1.7, it is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants