V2.2.1/migrate tests typescript#429
Open
atsignhandle wants to merge 3 commits intoopenlawteam:masterfrom
Open
Conversation
fforbeck
reviewed
Feb 2, 2022
| return await deployDao({ | ||
| ...hardHatImports, | ||
| deployFunction, | ||
| unitPrice: unitPrice, |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected property shorthand.
Suggested change
| unitPrice: unitPrice, | |
| unitPrice, |
fforbeck
reviewed
Feb 2, 2022
| if (!process.env.OFFCHAIN_ADMIN_ADDR) | ||
| throw Error("Missing env var: OFFCHAIN_ADMIN_ADDR"); | ||
| if (!process.env.VOTING_PERIOD_SECONDS) | ||
| throw Error("Missing env var: VOTING_PERIOD_SECONDS"); |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected { after 'if' condition.
Suggested change
| throw Error("Missing env var: VOTING_PERIOD_SECONDS"); | |
| {throw Error("Missing env var: VOTING_PERIOD_SECONDS");} |
fforbeck
reviewed
Feb 2, 2022
| if (!process.env.DAO_OWNER_ADDR) | ||
| throw Error("Missing env var: DAO_OWNER_ADDR"); | ||
| if (!process.env.ERC20_TOKEN_NAME) | ||
| throw Error("Missing env var: ERC20_TOKEN_NAME"); |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected { after 'if' condition.
Suggested change
| throw Error("Missing env var: ERC20_TOKEN_NAME"); | |
| {throw Error("Missing env var: ERC20_TOKEN_NAME");} |
fforbeck
reviewed
Feb 2, 2022
| }) | ||
| ); | ||
|
|
||
| if (ragequit) adapters.push(entryDao("ragequit", ragequit, {})); |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected { after 'if' condition.
Suggested change
| if (ragequit) adapters.push(entryDao("ragequit", ragequit, {})); | |
| if (ragequit) {adapters.push(entryDao("ragequit", ragequit, {}));} |
fforbeck
reviewed
Feb 2, 2022
|
|
||
| return { | ||
| dao: dao, | ||
| adapters: adapters, |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected property shorthand.
Suggested change
| adapters: adapters, | |
| adapters, |
fforbeck
reviewed
Feb 2, 2022
| }; | ||
|
|
||
| const loadOrDeploy = async (contract, factory, args) => { | ||
| if (!factory) return null; //throw Error("Invalid contract interface"); |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected { after 'if' condition.
Suggested change
| if (!factory) return null; //throw Error("Invalid contract interface"); | |
| if (!factory) {return null;} //throw Error("Invalid contract interface"); |
fforbeck
reviewed
Feb 2, 2022
| } | ||
|
|
||
| return { | ||
| dao: dao, |
Contributor
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected property shorthand.
Suggested change
| dao: dao, | |
| dao, |
fforbeck
force-pushed
the
master
branch
2 times, most recently
from
6445409 to
615146d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes