Skip to content

Conversation

GuySten
Copy link
Contributor

@GuySten GuySten commented Oct 6, 2025

Description

Currently, when openmc load weight windows from an hdf5 file the meshes are not loaded.
This PR change this behavior so the meshes inside the weight windows hdf5 file are also loaded.

Fixes #3588

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten requested a review from pshriwise October 6, 2025 04:25
@GuySten GuySten marked this pull request as ready for review October 6, 2025 07:05
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @GuySten. One comment on separating concerns. We'll also want to attempt some testing for this of course if you're up for taking a crack at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants