feat: Add headers to graphiQL UI #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nexus49
requested changes
Jan 27, 2025
internal/config/config.go
Outdated
| @@ -14,7 +14,7 @@ type Config struct { | |||
| type HandlerConfig struct { | |||
| Pretty bool `envconfig:"default=true,optional"` | |||
| Playground bool `envconfig:"default=true,optional"` | |||
| GraphiQL bool `envconfig:"default=true,optional"` | |||
| GraphiQL bool `envconfig:"GRAPHI_QL,default=true,optional"` | |||
There was a problem hiding this comment.
is this necessary? That should be the default behavior
There was a problem hiding this comment.
Do you mean set it to false by default? I can do that way as well.
I just wanted to set new graphiql UI as a default one.
There was a problem hiding this comment.
no i mean
GraphiQL bool `envconfig:"default=true,optional"`
should be sufficient
nexus49
approved these changes
Jan 28, 2025
vertex451
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraqhiQL is going to replace graqphl-playground. See graphql/graphql-playground#1366 (comment) (This comment is referrenced as future of graphql/graphql-playground repository in the root README)
But we have one more dependency point - github.com/graphql-go/handler that uses old version of GraqhiQL.
I created a PR graphql-go/handler#93 to propose newer version, and I am using
go mod replaceto that fork as a solution for us to fix autocomplete overlay issue.