Repository navigation
docker: interop client offers drafts 18 and 16 only - #770
Conversation
The relay no longer accepts draft-14, so the interop client stops offering moqt-15 and moq-00. Order keeps the binary's default preference for 18.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openmoq/moqx/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ChangesInterop client configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The image offers drafts 18 and 16, both supported by the checked-in default relay. No supported interoperability failure blocks merging; the external runner's exact relay configuration remains unverified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The relay no longer accepts draft-14. The interop client image now sets
MOQT_VERSIONS=18,16, so it offers the same drafts the relay accepts.Offered ALPNs, checked by running the published
moqx-interop-client:latestimage:MOQT_VERSIONSmoqt-18, moqt-16, moqt-15, moq-0018,16(after)moqt-18, moqt-16The order keeps the binary's default preference for 18. The interop runner doesn't set
MOQT_VERSIONS, so this default is what interop runs use.Related: englishm/moq-interop-runner#131 removes draft-14 from the moqx registration.
This change is
Summary by CodeRabbit