Skip to content

docker: interop client offers drafts 18 and 16 only - #770

Merged
gmarzot merged 1 commit into
mainfrom
devops/interop-client-drop-draft-14
Sep 28, 2026
Merged

gmarzot merged 1 commit into
mainfrom
devops/interop-client-drop-draft-14

Conversation

@gmarzot

@gmarzot gmarzot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

The relay no longer accepts draft-14. The interop client image now sets MOQT_VERSIONS=18,16, so it offers the same drafts the relay accepts.

Offered ALPNs, checked by running the published moqx-interop-client:latest image:

MOQT_VERSIONS Offered ALPNs
unset (before) moqt-18, moqt-16, moqt-15, moq-00
18,16 (after) moqt-18, moqt-16

The order keeps the binary's default preference for 18. The interop runner doesn't set MOQT_VERSIONS, so this default is what interop runs use.

Related: englishm/moq-interop-runner#131 removes draft-14 from the moqx registration.


This change is Reviewable

Summary by CodeRabbit

  • New Features
    • The interop client now supports drafts 18 and 16, preferring draft 18.

The relay no longer accepts draft-14, so the interop client stops offering moqt-15 and moq-00. Order keeps the binary's default preference for 18.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openmoq/moqx/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5de147c5-c066-43bc-8b26-ba7996f9710a

📥 Commits

Reviewing files that changed from the base of the PR and between a7aa988 and e11c40a.

📒 Files selected for processing (1)
  • docker/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The interop-client image now sets MOQT_VERSIONS to 18,16, with draft 18 first.

Changes

Interop client configuration

Layer / File(s) Summary
Set supported MOQT versions
docker/Dockerfile
The image sets MOQT_VERSIONS to 18,16.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: michalhosna

Merge Risk: ⚪ Minimal · up to e11c4

The image offers drafts 18 and 16, both supported by the checked-in default relay. No supported interoperability failure blocks merging; the external runner's exact relay configuration remains unverified.

Architecture Summary

Architecture risk: 🔵 Low · up to e11c4

The change affects 1 system.

Changed systems: docker

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — docker (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in docker/Dockerfile: The interop-client image now sets MOQT_VERSIONS to 18,16, preferring draft 18.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: the interop client offers only drafts 18 and 16.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@gmarzot
gmarzot requested a review from afrind September 28, 2026 16:58
@gmarzot gmarzot self-assigned this Sep 28, 2026
@gmarzot
gmarzot merged commit 888a3f1 into main Sep 28, 2026
13 checks passed
@gmarzot
gmarzot deleted the devops/interop-client-drop-draft-14 branch September 28, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants