TRUNK-6284: Add discontinue_reason and discontinue_reason_non_coded t…

[0abhi007]

Description of what I changed

JIRA: https://openmrs.atlassian.net/browse/TRUNK-6284?focusedCommentId=193037

Added discontinue_reason and discontinueReasonNonCoded fields to the Order domain object.

• Added discontinueReason (Concept) field to Order.java
• Added discontinueReasonNonCoded (String) field to Order.java
• Added getters, setters, and updated copyHelper method
• Added Liquibase migration to add the new columns to the orders table

Issue I worked on

TRUNK-6284

[0abhi007]

Hi @dkayiwa @ibacher @mseaton @wikumChamith - could you please review this PR when you get a chance?

This implements TRUNK-6284 - adds structured discontinuation reason support to the Order domain.

Thank you!

[vaalemax]

The implementation looks clean.
One thing to verify: does the copyHelper method handle the case where discontinueReason is null, to avoid NullPointerExceptions when copying Orders that were discontinued without a structured reason?
Also, it would be helpful to have at least one unit test covering the new fields in the Order domain.

[jwnasambu]

Kindly attach the correct ticket link on this PR please!

[0abhi007]

The implementation looks clean. One thing to verify: does the copyHelper method handle the case where discontinueReason is null, to avoid NullPointerExceptions when copying Orders that were discontinued without a structured reason? Also, it would be helpful to have at least one unit test covering the new fields in the Order domain.

The implementation looks clean. One thing to verify: does the copyHelper method handle the case where discontinueReason is null, to avoid NullPointerExceptions when copying Orders that were discontinued without a structured reason? Also, it would be helpful to have at least one unit test covering the new fields in the Order domain.

Thanks a lot for reviewing this, @vaalemax.

I will double‑check copyHelper to ensure it safely handles a null discontinueReason to avoid any potential NPEs when copying discontinued Orders without a structured reason.

I will also add unit tests covering the new discontinueReason and discontinueReasonNonCoded fields in the Order domain and update the PR accordingly.

[0abhi007]

Kindly attach the correct ticket link on this PR please!

Thanks for the review, @jwnasambu. I have attached the correct ticket link here:
https://openmrs.atlassian.net/browse/TRUNK-6284?focusedCommentId=193037

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud