(fix) O3-4183: Improve visit queue number attribute UUID handling in queue table #1366
Conversation
… service queues app
|
@ibacher kindly feel free to review my PR at your convenient time, please! Through the help of the coffee break team, I was unable to reproduce the bug. Kindly what could be the steps to reproduce the issue? |
NethmiRodrigo
changed the title
| className={`${styles.admissionRequestsContainer} ${ | ||
| inpatientRequests?.length ? styles.blackBackground : styles.lightBlueBackground | ||
| }`}> |
There was a problem hiding this comment.
nit: Prefer using classnames here.
There was a problem hiding this comment.
@denniskigen Kindly, I am somehow confused. This is not part of my changes, though I don't mind fixing the issue. I made changes on one file and would like to know why I have 8 files changed.
There was a problem hiding this comment.
Looks like changes from linting
There was a problem hiding this comment.
Resolved in this commit. For whatever reason, some files in the Ward app were not getting linted using our prettier config. I've fixed that. So all you need to do is rebase against main.
There was a problem hiding this comment.
@denniskigen Thanks for the fix and follow-up. I have fixed the merge conflicts, too.
jwnasambu
force-pushed
the
feat/O3-4183
branch
from
f22db3f to
e7c46bb
Compare
|
LGTM. Thanks. Maybe a PR title like |
jwnasambu
changed the title
|
@denniskigen I consent your suggestion is much better compared to what I had before. |
|
Thanks, @jwnasambu! |
Requirements
Summary
I modified the code to log an error to the console when visitQueueNumberAttributeUuid is not configured and omit the column from the queue table.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4183
Other