-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BED-19 and BED-20 Fixes bugs in bed administration UI #1437
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Also, all PRs should have an associated JIRA ticket that describes the change that can be tracked. Please create one and refer to it in the commit title and comment.
packages/esm-bed-management-app/src/bed-administration/bed-administration-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-bed-management-app/src/bed-administration/bed-administration-form.component.tsx
Outdated
Show resolved
Hide resolved
This is a bit weird, but while I can recreate the underlying issue this PR fixes on dev3, it doesn't happen locally on main. Screen.Recording.2025-01-15.at.1.59.24.PM.movAlso, I added a console log to check and onChange does get fired: Screen.Recording.2025-01-15.at.2.03.57.PM.mov |
I checked only in the distro not with the local build. My assumption is that the current used version of @carbon/react in production mode has exactly this issue: carbon-design-system/carbon#18145 (comment) onChange was not fired when I tested in the bundled distro Just for reference - this happenes to be after mouting the bed module production build inside the latest main distro: 2025-01-15.14-41-35.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks!
Requirements
Summary
Screenshots
Related Issues
https://openmrs.atlassian.net/browse/BED-19
https://openmrs.atlassian.net/browse/BED-20
Other