Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BED-19 and BED-20 Fixes bugs in bed administration UI #1437

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jbravo94
Copy link

@jbravo94 jbravo94 commented Jan 12, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

image

Related Issues

https://openmrs.atlassian.net/browse/BED-19
https://openmrs.atlassian.net/browse/BED-20

Other

  • Result was manually tested
  • Other translations files would need updates of the keys as well - feedback required.

@mogoodrich
Copy link
Member

Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Also, all PRs should have an associated JIRA ticket that describes the change that can be tracked. Please create one and refer to it in the commit title and comment.

@NethmiRodrigo
Copy link
Collaborator

NethmiRodrigo commented Jan 15, 2025

This is a bit weird, but while I can recreate the underlying issue this PR fixes on dev3, it doesn't happen locally on main.

Screen.Recording.2025-01-15.at.1.59.24.PM.mov

Also, I added a console log to check and onChange does get fired:

Screen.Recording.2025-01-15.at.2.03.57.PM.mov

@jbravo94
Copy link
Author

jbravo94 commented Jan 15, 2025

I checked only in the distro not with the local build. My assumption is that the current used version of @carbon/react in production mode has exactly this issue: carbon-design-system/carbon#18145 (comment)

onChange was not fired when I tested in the bundled distro

@NethmiRodrigo

Just for reference - this happenes to be after mouting the bed module production build inside the latest main distro:

2025-01-15.14-41-35.mp4

@jbravo94 jbravo94 changed the title Fixes bugs in bed administration UI BED-19 and BED-20 Fixes bugs in bed administration UI Jan 15, 2025
@jbravo94 jbravo94 requested a review from mseaton January 15, 2025 14:24
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants