Refactor: Extract and clean up ReceiptGenerator#createBillReceipt#152
Open
rak626 wants to merge 2 commits intoopenmrs:mainfrom
Open
Refactor: Extract and clean up ReceiptGenerator#createBillReceipt#152rak626 wants to merge 2 commits intoopenmrs:mainfrom
rak626 wants to merge 2 commits intoopenmrs:mainfrom
Conversation
rak626
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Extract and clean up ReceiptGenerator#createBillReceipt
Summary
The
createBillReceiptmethod was a single ~300-line method mixing PDFlayout construction, font loading, logo resolution, number formatting,
and document assembly in one place, making it hard to read and maintain.
Changes
loadFonts()returning aReceiptFontsvalue objectresolveLogoUrl()andloadLogoImage()buildNumberFormat()buildLogoSection,buildReceiptHeader,buildLineItemsTable,buildTotalsSection,buildPaymentSection,buildAmountDueSection,buildFooterBillingPdfConstantsNo behaviour changes
This is a pure refactor. Output PDF is identical to before.
Testing
@wikumChamith @ibacher please review & merge it.