HTMLWIDGETS-26: Migrate to Platfrom 2.7.0 and Support Java 21#9
Merged
dkayiwa merged 2 commits intoopenmrs:masterfrom May 19, 2025
Merged
HTMLWIDGETS-26: Migrate to Platfrom 2.7.0 and Support Java 21#9dkayiwa merged 2 commits intoopenmrs:masterfrom
dkayiwa merged 2 commits intoopenmrs:masterfrom
Conversation
dkayiwa
reviewed
May 16, 2025
| package org.openmrs.module.htmlwidgets.web.demo; | ||
|
|
||
| public enum PatientLocationMethod { | ||
| EARLIEST_ENCOUNTER, |
Member
Author
There was a problem hiding this comment.
This enum has been moved to the reportingcompatibility module. Instead of introducing a new dependency on that module, I decided to copy the enum directly into this module.
Member
There was a problem hiding this comment.
Is it used anywhere apart from tests?
Member
Author
There was a problem hiding this comment.
Yeah, it is only used in the Demo class, so I decided to move the enum to that class.
wikumChamith
force-pushed
the
HTMLWIDGETS-26
branch
2 times, most recently
from
5aea694 to
947ae7f
Compare
Member
|
Are you also going to create a branch and bump the module version? |
wikumChamith
force-pushed
the
HTMLWIDGETS-26
branch
from
c6d02c1 to
4aa7678
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://openmrs.atlassian.net/browse/HTMLWIDGETS-26