FLAG-19 : Exception when Saving Flag Without Message #22
Open
RishavR wants to merge 1 commit intoopenmrs:masterfrom
RishavR:flag-19
Open
FLAG-19 : Exception when Saving Flag Without Message #22RishavR wants to merge 1 commit intoopenmrs:masterfrom RishavR:flag-19
RishavR wants to merge 1 commit intoopenmrs:masterfrom
RishavR:flag-19
Conversation
Changes made to display error message to the user if the 'Message' field is empty. Changes done for both En and Fr languages.
Author
dkayiwa
reviewed
Apr 23, 2019
| patientflags.errors.priorityNameTooLong=Name can only be 255 characters in length | ||
| patientflags.errors.styleTooLong=Style can only be 255 characters in length | ||
| patientflags.errors.invalidUsername=No user with that username No newline at end of file | ||
| patientflags.errors.invalidUsername=No user with that username |
Member
There was a problem hiding this comment.
Has the above line got anything to do with this ticket?
Member
|
Hello @RishavR ,Are you still interested in finishing this ticket. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Made changes to the following methods in omod to ensure that if user does not enter a message in 'Edit Flags', it displays an error message instead of leading to the exception page:
Method - validate()
Method - validate()
Also made changes to the following properties files in API to include Error Message when message field is empty:
Issues I worked on
https://issues.openmrs.org/browse/FLAG-19
Screenshot