FLAG-69: Improve the performance of patient flag evaluation#59
Open
ManojLL wants to merge 3 commits intoopenmrs:masterfrom
Open
FLAG-69: Improve the performance of patient flag evaluation#59ManojLL wants to merge 3 commits intoopenmrs:masterfrom
ManojLL wants to merge 3 commits intoopenmrs:masterfrom
Conversation
Member
|
@ManojLL can you fix the merge conflicts? |
61aa5e9 to
1750407
Compare
b9a9d6d to
e268e23
Compare
e268e23 to
a1e4aa6
Compare
| executor = Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()); | ||
| // test each Flag in the cache against the specific Patient | ||
| for (Flag flag : filter.filter(flagCache)) { | ||
| for (final Flag flag : filter.filter(flagCache)) { |
Member
There was a problem hiding this comment.
Can we switch to streams here?
Contributor
Author
There was a problem hiding this comment.
updated the code with forEach
| executor = Executors.newSingleThreadExecutor(); | ||
| } | ||
|
|
||
| executor = Executors.newSingleThreadExecutor(); |
Member
There was a problem hiding this comment.
why did you remove the null check here?
Contributor
Author
There was a problem hiding this comment.
in this line , I initialized the executor as a thread pool. If the generateFlagForPatient method is called first, the executor is already initialized as thread pool, so then evaluateAllFlags uses a thread pool instead of a single thread. after removing the null check when evaluateAllFLag method calls it initialize the executor as a single thread.
c3875a8 to
8d3a634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I change
change to evaluate patient flags in parallely on generateFlagsForPatient(...) method.
Issue Worked On
worked on FLAG-69
Test
use the method execution time in milliseconds (ms) to evaluate the performance.
Generate flags for patient
Generate flags for patient
parallel process -> 7.6.5.8,7,7,6,7,8,6 => avg 6.7 milliseconds
current module -> 8,7,7,6,8,7,7,7,8,6 => avg 7.1 milliseconds
flags count < 5 - current module perform better than this implementations
flags count < 10 - both are perform in same way
flags count = 17 - this implementation perform better than current module
when the flag count is increased, the prell process performs better than the current module.
method test : generate flags for patient : FalgServiceImpl.generateFlagsForPatient(Patient patient, Context)