FLAG-76: Implement batch saving functionality for generatePatinetFlags() #71
Open
ManojLL wants to merge 1 commit intoopenmrs:masterfrom
Open
FLAG-76: Implement batch saving functionality for generatePatinetFlags() #71ManojLL wants to merge 1 commit intoopenmrs:masterfrom
ManojLL wants to merge 1 commit intoopenmrs:masterfrom
Conversation
ManojLL
changed the title
ManojLL
force-pushed
the
FLAG-76-generatePatientFlags
branch
2 times, most recently
from
63428af to
33abbae
Compare
sherrif10
reviewed
Jul 1, 2024
| } | ||
|
|
||
| @Test | ||
| public void savePatientFLags_shouldAcceptListPfPatientFlag() { |
Member
There was a problem hiding this comment.
Suggested change
| public void savePatientFLags_shouldAcceptListPfPatientFlag() { | |
| public void savePatientFLags_shouldAcceptListOfPatientFlag() { | |
FLAG 76: added batch saving for generate patient flag for flags FLAG 76: added unit tests for batch saving FLAG 76: added unit tests for batch saving
ManojLL
force-pushed
the
FLAG-76-generatePatientFlags
branch
from
33abbae to
5497369
Compare
Member
|
@ManojLL have you noticed a performance increase with this? |
Contributor
Author
yes @wikumChamith, I noticed a difference in execution time between batch saving and without batch saving
without batch saving : 79.9 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue worked on : FLAG-76