Skip to content

REPORT-823: Improved the preview pages query definitions.#172

Open
sstream17 wants to merge 1 commit intoopenmrs:masterfrom
soft261:REPORT-823
Open

REPORT-823: Improved the preview pages query definitions.#172
sstream17 wants to merge 1 commit intoopenmrs:masterfrom
soft261:REPORT-823

Conversation

@sstream17
Copy link

@sstream17 sstream17 commented Apr 19, 2019 •
edited
Loading

Description

  • Cohort Queries

    • Previously, the preview page for cohort query definitions did not display enough information; only the size of the cohort was shown.
    • Now, the preview page for cohort query definitions shows a pageable list of patient IDs in the cohort.

  • Person Queries

    • Previously, the preview page for person query definitions displayed too much information; the table was often too long and required scrolling to see all of the entries.
    • Now, the preview page for person query definitions shows a pageable list of patient IDs.

  • The preview pages for both cohort and person query definitions now share the same style to create a consistent look among the two.

Issue

https://issues.openmrs.org/browse/REPORT-823

Checklist:

  • My pull request only contains one single commit.
  • My pull request is based on the latest master branch
    git pull --rebase upstream master.
  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.
  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dkayiwa
dkayiwa reviewed Apr 23, 2019
View reviewed changes
omod/src/main/java/org/openmrs/module/reporting/web/taglib/FormatTag.java
private Integer conceptId;

private Concept concept;
Copy link
Member

@dkayiwa dkayiwa Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of formatting changes in this pull request. Can you discard them?

Copy link
Author

@sstream17 sstream17 May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkayiwa I have updated the pull request to discard the formatting changes.

@sstream17
REPORT-823: Improved the preview pages of query definitions.
e286876 
* Cohort Queries
  * Previously, the preview page for cohort query definitions did not display enough
information; only the size of the cohort was shown.
  * Now, the preview page for cohort query definitions shows a pageable list of patient IDs in
the cohort.
* Person Queries
  * Previously, the preview page for person query definitions displayed too much information;
the table was often too long and required scrolling to see all of the entries.
  * Now, the preview page for person query definitions shows a pageable list of patient IDs.

* The preview pages for both cohort and person query definitions now share the same style to
create a consistent look among the two.
@dkayiwa
Copy link
Member

dkayiwa commented May 8, 2019

Did you get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

@sstream17
Copy link
Author

sstream17 commented May 12, 2019

Did you get a chance to look at this? https://wiki.openmrs.org/display/docs/Pull+Request+Tips

I have looked at that. Is there anything I missed?

@dkayiwa
Copy link
Member

dkayiwa commented May 12, 2019

Did you read about the JIRA workflow?

@sstream17
Copy link
Author

sstream17 commented May 14, 2019 •
edited
Loading

Click the "Request Code Review" or "Ready for Testing" button in JIRA for the ticket to notify us that it is ready for review.

I am unsure where to find these buttons. I have made a comment on the ticket with a link to the pull request however.

@sstream17
Copy link
Author

sstream17 commented Jun 8, 2019

@dkayiwa Is there anything else I can do to finish this pull request?

@dkayiwa
Copy link
Member

dkayiwa commented Aug 12, 2019

I have just commented on the ticket.

@sstream17
Copy link
Author

sstream17 commented Oct 6, 2019

@dkayiwa Is there anything else I can do to finish this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkayiwa dkayiwa dkayiwa left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sstream17 @dkayiwa