REPORT-921: Fix null cohortQuery parameter in addColumn method#266
Open
AdityaBharatiya wants to merge 1 commit intoopenmrs:masterfrom
Open
REPORT-921: Fix null cohortQuery parameter in addColumn method#266AdityaBharatiya wants to merge 1 commit intoopenmrs:masterfrom
AdityaBharatiya wants to merge 1 commit intoopenmrs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the "Cannot add an indicator" error (REPORT-921).
Jira Ticket: https://openmrs.atlassian.net/browse/REPORT-921
Problem: The addColumn method expected a full CohortDefinition object from a @RequestParam, which Spring cannot convert, causing a MissingServletRequestParameterException.
Solution: Changed the parameter to accept a UUID string and added code to fetch the CohortDefinition from the service layer, following the existing pattern used for the ReportDefinition parameter.
Note: I've verified the fix compiles successfully (mvn clean install). As I'm still setting up a complete local test environment, I haven't been able to perform full end-to-end UI testing for this specific workflow. I would be grateful if the reviewers could help verify the functionality during their review. I'm eager to learn and contribute more to the OpenMRS community.