-
Notifications
You must be signed in to change notification settings - Fork 64
Add option for regional cache to skip tagCache on cache hits #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for regional cache to skip tagCache on cache hits #850
Conversation
🦋 Changeset detectedLatest commit: 6082569 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe just add some comment about the need for a custom domain
packages/cloudflare/src/api/overrides/incremental-cache/regional-cache.ts
Outdated
Show resolved
Hide resolved
packages/cloudflare/src/api/overrides/incremental-cache/regional-cache.ts
Outdated
Show resolved
Hide resolved
When the `regional-cache` is used and it finds an entry, there's no need to then interact with the `tagCache`, so the changes here add `shouldBypassTagCache: true` to the cache response to avoid interactions with the tagCache (which can slow down response times)
…al-cache.ts Co-authored-by: conico974 <[email protected]>
f24ab92
to
49cd870
Compare
packages/cloudflare/src/api/overrides/incremental-cache/regional-cache.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: James Anderson <[email protected]>
No description provided.