fix: revert "fix(perf): exclude /_next/static/* from generated functions (#3100)"
#3123
+7
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
reviewed
Sep 12, 2025
| @@ -98,7 +98,7 @@ export const test = base.extend< | |||
| if (response.url().includes('/_next/static/')) { | |||
| expect( | |||
| response.headers()['cache-control'], | |||
| `_next/static asset (${response.url()}) should have immutable cache control`, | |||
| '_next/static assets should have immutable cache control', | |||
There was a problem hiding this comment.
Could optionally keep this change
There was a problem hiding this comment.
I think we can re-add it later, ideally we end up with some solution that does exclude _next/static from lambda without causing 404s to have public,max-age=31536000, immutable.
I don't want to delay merging and releasing it by doign adjustments here
There was a problem hiding this comment.
#3124 For the restoration of this and the i18n+basePath test adjustments
📊 Package size report -0.02%↓
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
reviewed
Sep 12, 2025
| @@ -1382,15 +1352,13 @@ test.describe('Page Router with basePath and i18n', () => { | |||
|
|
|||
| test('requesting a non existing page route that needs to be fetched from the blob store like 404.html', async ({ | |||
| page, | |||
| pageRouterBasePathI18n, | |||
There was a problem hiding this comment.
I think we still want these test changes
mrstork
approved these changes
Sep 12, 2025
pieh
changed the title
/_next/static/* from generated functions (#3100)"/_next/static/* from generated functions (#3100)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5e28132.
Description
#3100 caused not intended bug where
_next/static404s getpublic,max-age=31536000, immutablewhich is wrong - that should only be applied to 200sFixes #3119
BEGIN_COMMIT_OVERRIDE
fix: revert "fix(perf): exclude /_next/static/* from generated functions (#3100)"
END_COMMIT_OVERRIDE