Skip to content

test: fix i18n+basePath test to use correct fixture #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2025
Merged

test: fix i18n+basePath test to use correct fixture #3124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21f97db
test: log _next/static url if it doesn't contain permanent caching he…
pieh Sep 12, 2025
36c618c
test: fix i18n+basePath test to use correct fixture
pieh Sep 12, 2025
27e1b51
Merge branch 'main' into test-i18n-base-path-fix
pieh Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/e2e/page-router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1352,13 +1352,15 @@ test.describe('Page Router with basePath and i18n', () => {

test('requesting a non existing page route that needs to be fetched from the blob store like 404.html', async ({
page,
pageRouter,
pageRouterBasePathI18n,
}) => {
const response = await page.goto(new URL('non-existing', pageRouter.url).href)
const response = await page.goto(
new URL('base/path/non-existing', pageRouterBasePathI18n.url).href,
)
const headers = response?.headers() || {}
expect(response?.status()).toBe(404)

expect(await page.textContent('p')).toBe('Custom 404 page')
expect(await page.textContent('p')).toBe('Custom 404 page for locale: en')

expect(headers['debug-netlify-cdn-cache-control']).toMatch(
/no-cache, no-store, max-age=0, must-revalidate, durable/m,
Expand All @@ -1368,13 +1370,15 @@ test.describe('Page Router with basePath and i18n', () => {

test('requesting a non existing page route that needs to be fetched from the blob store like 404.html (notFound: true)', async ({
page,
pageRouter,
pageRouterBasePathI18n,
}) => {
const response = await page.goto(new URL('static/not-found', pageRouter.url).href)
const response = await page.goto(
new URL('base/path/static/not-found', pageRouterBasePathI18n.url).href,
)
const headers = response?.headers() || {}
expect(response?.status()).toBe(404)

expect(await page.textContent('p')).toBe('Custom 404 page')
expect(await page.textContent('p')).toBe('Custom 404 page for locale: en')

// Prior to v14.2.4 notFound pages are not cacheable
// https://github.com/vercel/next.js/pull/66674
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/playwright-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const test = base.extend<
if (response.url().includes('/_next/static/')) {
expect(
response.headers()['cache-control'],
'_next/static assets should have immutable cache control',
`_next/static asset (${response.url()}) should have immutable cache control`,
).toContain('public,max-age=31536000,immutable')
}
})
Expand Down
Loading