-
Notifications
You must be signed in to change notification settings - Fork 204
Add scipts to monitor nginx ssl session ticket keys and session ticket r... #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add scipts to monitor nginx ssl session ticket keys and session ticket r... #7
Conversation
change code style and file naming style. Make them consistent with existing ones. |
tapset/nginx/openssl_ex_data.sxx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I still don't like this module name. given that all these functions are related to OpenSSL only (and not nginx at all), you should probably just name it openssl
instead of nginx.openssl_ex_data
. Thoughts?
@lziest Also, will you add some corresponding docs to the file |
941888d
to
3eb5acd
Compare
Add docs, squashed minor changes and rebased. |
tapset/nginx/openssl.sxx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename it to just openssl
because this module has nothing to do with nginx.
Please |
README.markdown
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a line to set PATH environment, just like the docs for other tools. Thank you :)
72bb100
to
bba6a34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you add some sample outputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add sample outputs here in its docs and also some brief explanation if not too obvious.
@lziest Please add support for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this tool should exit here as soon as it dumps the first key set. Thoughts?
I would like to squash the commits into one once it's ok to merge |
README.markdown
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no indentation in the output? It's hard to look ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, still miss that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found these ratio descriptions a bit confusing. Maybe you can make it even clearer? How about these:
Ticket resumption attempts ratio in all SSL sessions: %d
Ticket resumption success ratio in all attempts: %d
Resumed ticket sessions in all SSL sessions: %d
...esumptions.