Stepbuilder chunk issue #781
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 5, 2025 06:38
…hods This is removed in SpringBoot 5.2 and the 5.0 recipe is already removing @Autowired fields. I thought I would have to do something like this for `JobBuilderFactory`, but its recipe is already doing somethign like this. It's a little unclear why there's more testing in this `StepBuilderFactory` case than there is for `JobBuilderFactory`. Regardless, this class is removed, and I'm hoping this will solve many cases for us (and others!). openrewrite#779
from front of method argument list. openrewrite#779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick reproducer of the problem described in this discussion. Hard to believe this is a rewrite-spring issue, but needed to make something quick. I tried to recreate this in
rewritewith inlined test classes, but couldn't quickly do that.What's your motivation?
I need to finish a recipe that converts
chunk(int), which is deprecated, tochunk(int, PlatformTransactionManager).Checklist