732: Remove trailing whitespace

[dsgrieve]

What's changed?

Recipe to remove trailing whitespace

What's your motivation?

Fixes #732

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Patterned after other RemoveTrailingWhitespace recipes in openrewrite/rewrite.

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Jenson3210]

Suggested change

	input.append("Line ").append(i);
	expected.append("Line ").append(i);
	// Add i spaces as trailing whitespace
	for (int j = 0; j < i; j++) {
	input.append(" ");
	}
	input.append("Line ").append(i).repeat(" ", i);
	expected.append("Line ").append(i);

Java 21 has this new repeat method on StringBuilder

[dsgrieve]

Added in Java 11, IIRC.

[Jenson3210]

I meant: the tests run in Java 21, so this could be used here, no?

[Jenson3210]

A PlainTextVisitor does not act on Java files. If you would want to "downcast" the Java lst as a text lst, you could build a generic TreeVisitor that does that conversion.

In this case though you do not want to do that as you will loose all rich information of the lst and every recipe that should run on java files after this one will not make any changes as the Lst's at that moment are no longer JavaSourceFiles but PlainText Sourcefiles causing the isAcceptable of the JavaVisitor to skip the converted files.

[Jenson3210]

see https://moderneinc.slack.com/archives/C088P8067NH/p1757442137104209

[github-actions]

Suggested change

	"Line with trailing spaces \n" +
	"Line without trailing spaces\n" +
	"Another line with spaces \n",
	"Line with trailing spaces\n" +
	"Line without trailing spaces\n" +
	"Another line with spaces\n"
	"""
	Line with trailing spaces \s
	Line without trailing spaces
	Another line with spaces \s
	""",
	"""
	Line with trailing spaces
	Line without trailing spaces
	Another line with spaces
	"""

[github-actions]

Suggested change

	"Line with trailing tabs\t\t\n" +
	"Line without trailing tabs\n" +
	"Mixed tabs and spaces\t \n",
	"Line with trailing tabs\n" +
	"Line without trailing tabs\n" +
	"Mixed tabs and spaces\n"
	"""
	Line with trailing tabs
	Line without trailing tabs
	Mixed tabs and spaces \s
	""",
	"""
	Line with trailing tabs
	Line without trailing tabs
	Mixed tabs and spaces
	"""

[github-actions]

Suggested change

	"First line\n" +
	"Second line ",
	"First line\n" +
	"Second line"
	"""
	First line
	Second line """,
	"""
	First line
	Second line"""

[github-actions]

Suggested change

	"Line 1 \n" +
	"\n" +
	"Line 3\t\n" +
	"\n" +
	"Line 5",
	"Line 1\n" +
	"\n" +
	"Line 3\n" +
	"\n" +
	"Line 5"
	"""
	Line 1 \s
	Line 3
	Line 5""",
	"""
	Line 1
	Line 3
	Line 5"""

[github-actions]

Suggested change

	"Spaces then tabs \t\t\n" +
	"Tabs then spaces\t\t \n" +
	"Mixed whitespace \t \t \n",
	"Spaces then tabs\n" +
	"Tabs then spaces\n" +
	"Mixed whitespace\n"
	"""
	Spaces then tabs
	Tabs then spaces \s
	Mixed whitespace \s
	""",
	"""
	Spaces then tabs
	Tabs then spaces
	Mixed whitespace
	"""

[github-actions]

Suggested change

	"Clean line 1\n" +
	"Clean line 2\n" +
	"Clean line 3"
	"""
	Clean line 1
	Clean line 2
	Clean line 3"""

[github-actions]

Suggested change

	"line with content\n" +
	" \n" +
	"another line",
	"line with content\n" +
	"\n" +
	"another line"
	"""
	line with content
	\s
	another line""",
	"""
	line with content
	another line"""

[github-actions]

Suggested change

	" Indented line \n" +
	"\tTab indented line\t\n" +
	" Mixed indentation\t ",
	" Indented line\n" +
	"\tTab indented line\n" +
	" Mixed indentation"
	"""
	Indented line \s
	Tab indented line
	Mixed indentation """,
	"""
	Indented line
	Tab indented line
	Mixed indentation"""