-
Notifications
You must be signed in to change notification settings - Fork 458
Implement module imports in Java 25 parser #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This concerns me a little, as that means On the other hand we can choose to add it to |
rewrite-java-tck/src/main/java/org/openrewrite/java/tree/ImportTest.java
Show resolved
Hide resolved
As a quick thought: once we have merged the parser support, we'll likely also want to adapt the style detection to figure out at which point to switch from explicit imports to module imports, much like we do for wildcard imports. That tally can then factor into |
return t.statik == statik ? t : new Import(t.id, t.prefix, t.markers, statik, t.module, t.qualid, t.alias); | ||
} | ||
|
||
public JLeftPadded<Boolean> getModule() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at least the getter here also needs to be @Nullable
.
What's changed?
Add support for module imports in the Java 25 parser
What's your motivation?
Making the parser idempotent
Checklist