Add caching to JavaParser.fromJavaVersion()
#6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoiding calling `Class.forName()` is important in concurrent environments. As the method always returns a parser that corresponds to the JDK version and the `JavaParser` class should be loaded by the system class loader, it should be safe to cache the result.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rewrite-java/src/main/java/org/openrewrite/java/JavaParser.java
Outdated
Show resolved
Hide resolved
jkschneider
reviewed
Sep 11, 2025
rewrite-java/src/main/java/org/openrewrite/java/JavaParser.java
Outdated
Show resolved
Hide resolved
# Conflicts: # rewrite-java/src/main/java/org/openrewrite/java/JavaParser.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoiding calling
Class.forName()is important in concurrent environments. As the method always returns a parser that corresponds to the JDK version and theJavaParserclass should be loaded by the system class loader, it should be safe to cache the result.