Skip to content

Warm Index local file delete failure fix #19110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Warm Index local file delete failure fix #19110

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd66d58
For the WarmIndex if the file deletion (which is triggered as part of…
Aug 20, 2025
026e3cd
added the missing import
Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion server/src/main/java/org/opensearch/index/store/CompositeDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

import java.io.FileNotFoundException;
import java.io.IOException;
import java.nio.file.AccessDeniedException;
import java.nio.file.Files;
import java.nio.file.NoSuchFileException;
import java.nio.file.Path;
Expand Down Expand Up @@ -188,7 +189,18 @@ not present in remote as well (due to metadata refresh). In such scenarios listA
logger.debug("The file [{}] exists in local but not part of FileCache, deleting it from local", blockFile);
localDirectory.deleteFile(blockFile);
} else {
fileCache.remove(getFilePath(blockFile));
// here the file is to be deleted both from FileCache and the local directory.
Path blockFilePath = getFilePath(blockFile);
try {
fileCache.remove(blockFilePath);
}catch(Exception e){
if (e.getCause() instanceof AccessDeniedException) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can catch a specific type of Exception in catch instead of getting the exception from cause and doing an instanceof check ?

We should avoid instanceof checks if possible.

localDirectory.deleteFile(blockFile);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a debug log as well on this, might prove useful for understanding how frequent the deletions fail

} else {
logger.error("Exception while removing file [{}] from FileCache. Exception:", blockFilePath, e);
throw e;
}
}
}
}
}
Expand Down
Loading