Fix: Include script params in BulkRequest size calculation #19127
+30
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for 266e445: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ef5cc17: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
mbohm-atl
commented
Aug 22, 2025
The BulkRequest's size calculation in internalAdd(UpdateRequest) method currently doesn't account for the size of script parameters. This can lead to underestimating the actual request size when script parameters are used. Added script parameters size calculation using script.getParams().toString().length() Signed-off-by: Marcin Böhm <[email protected]>
mbohm-atl
force-pushed
the
fix/bulk/request-size-script-params
branch
from
ef5cc17 to
367bcfa
Compare
|
❌ Gradle check result for 367bcfa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
This PR is stalled because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The BulkRequest's size calculation currently doesn't account for the size of script parameters in update operations. This can lead to underestimating the actual request size when script parameters are used, potentially causing memory-related issues in bulk operations.
Changes
BulkRequest.internalAdd(UpdateRequest)script.getParams().toString().length()Example Use Case
When using bulk updates with scripted updates that contain parameters: