Bump log4j2 from 2.21.0 to 2.25.1 #19184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

cwperks merged 1 commit into opensearch-project:main from willyborankin:bump-log4j2

Sep 17, 2025

Contributor

willyborankin commented Aug 29, 2025

Description

Bump log4j2 from 2.21.0 to 2.25.1

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

willyborankin force-pushed the bump-log4j2 branch 2 times, most recently from e7aa42e to 82a7e2e Compare

August 29, 2025 19:00

Contributor

github-actions bot commented Aug 29, 2025

❌ Gradle check result for 82a7e2e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 82a7e2e to 78e7fdf Compare

August 30, 2025 06:11

Contributor

github-actions bot commented Aug 30, 2025

❌ Gradle check result for 78e7fdf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 78e7fdf to 928fa14 Compare

September 1, 2025 23:00

Contributor

github-actions bot commented Sep 1, 2025

❌ Gradle check result for 928fa14: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 928fa14 to cec34b0 Compare

September 2, 2025 14:42

Contributor

github-actions bot commented Sep 2, 2025

❌ Gradle check result for cec34b0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch 2 times, most recently from db27748 to 6d1cdd1 Compare

September 2, 2025 15:22

Contributor

github-actions bot commented Sep 2, 2025

❌ Gradle check result for 6d1cdd1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 6d1cdd1 to 5422987 Compare

September 2, 2025 16:34

Contributor

github-actions bot commented Sep 2, 2025

❌ Gradle check result for 5422987: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 5422987 to 06db206 Compare

September 5, 2025 19:35

Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for 06db206: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 06db206 to 0cd8253 Compare

September 5, 2025 19:46

Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for 0cd8253: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 0cd8253 to 897a611 Compare

September 5, 2025 19:58

Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for 897a611: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 897a611 to 15aed40 Compare

September 5, 2025 20:31

Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for 15aed40: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch 2 times, most recently from ca5c631 to 6e1510e Compare

September 5, 2025 21:04

Contributor

github-actions bot commented Sep 5, 2025

❌ Gradle check result for 6e1510e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin marked this pull request as ready for review

September 5, 2025 23:28

willyborankin requested a review from a team as a code owner

September 5, 2025 23:28

willyborankin force-pushed the bump-log4j2 branch from 6e1510e to 7ec9ece Compare

September 6, 2025 11:36

Contributor

github-actions bot commented Sep 6, 2025

❌ Gradle check result for 7ec9ece: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 7ec9ece to 5fcf8ec Compare

September 6, 2025 15:40

willyborankin requested review from owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja and sohami as code owners

September 13, 2025 17:44

Contributor

github-actions bot commented Sep 13, 2025

❌ Gradle check result for 275c093: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

willyborankin force-pushed the bump-log4j2 branch from 275c093 to c5d6e27 Compare

September 13, 2025 18:35

Contributor

github-actions bot commented Sep 13, 2025

❌ Gradle check result for c5d6e27: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for ExampleSystemIngestProcessorClientYamlTestSuiteIT #18484

Open

Contributor

github-actions bot commented Sep 15, 2025

✅ Gradle check result for c5d6e27: SUCCESS

codecov bot commented Sep 15, 2025 •

edited

Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.92%. Comparing base (10f8c8e) to head (c30f407).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #19184      +/-   ##
============================================
+ Coverage     72.85%   72.92%   +0.07%     
- Complexity    69794    69816      +22     
============================================
  Files          5673     5673              
  Lines        320711   320754      +43     
  Branches      46360    46369       +9     
============================================
+ Hits         233642   233922     +280     
+ Misses        68143    67863     -280     
- Partials      18926    18969      +43

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

willyborankin force-pushed the bump-log4j2 branch from c5d6e27 to afb6306 Compare

September 15, 2025 17:55

Contributor

github-actions bot commented Sep 15, 2025

✅ Gradle check result for afb6306: SUCCESS

msfroh reviewed

View reviewed changes

Contributor

msfroh left a comment

Thanks a lot @willyborankin! Just a couple of minor comments.

gradle/libs.versions.toml Outdated Show resolved Hide resolved

modules/transport-grpc/build.gradle Outdated Show resolved Hide resolved

willyborankin force-pushed the bump-log4j2 branch from afb6306 to c30f407 Compare

September 17, 2025 08:34


          Bump log4j2 from 2.21.0 to 2.25.1

c30f407

Signed-off-by: Andrey Pleskach <[email protected]>

Contributor

github-actions bot commented Sep 17, 2025

✅ Gradle check result for c30f407: SUCCESS

cwperks approved these changes

View reviewed changes

cwperks merged commit b9c5bc7 into opensearch-project:main

31 checks passed

This was referenced Sep 17, 2025

[AUTOCUT] Gradle Check Flaky Test Report for IndexServiceTests #14407

Open

[AUTOCUT] Gradle Check Flaky Test Report for IngestFromKafkaIT #17215

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteClusterStateServiceTests #19325

Open

navneet1v reviewed

View reviewed changes

gradle/libs.versions.toml

    
              supercsv          = "2.4.0"

              log4j             = "2.21.0"

              log4j             = "2.25.1"

              error_prone_annotations = "2.41.0"

Contributor

navneet1v Sep 21, 2025 •

edited

Loading

is there a reason for upgrading error_prone_annotations to 2.41.0 version when guava 33.2.1-jre brings in 2.26.1 ?

Due to this mismatch, now plugins like k-NN who uses guava has to remove error_prone_annotations so that there is no jar hell

jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request


          Bump log4j2 from 2.21.0 to 2.25.1 (opensearch-project#19184)

f40559a

Signed-off-by: Andrey Pleskach <[email protected]>

jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request


          Bump log4j2 from 2.21.0 to 2.25.1 (opensearch-project#19184)

72a7871

Signed-off-by: Andrey Pleskach <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>

jainankitk pushed a commit to jainankitk/OpenSearch that referenced this pull request


          Bump log4j2 from 2.21.0 to 2.25.1 (opensearch-project#19184)

0bc7bd5

Signed-off-by: Andrey Pleskach <[email protected]>
Signed-off-by: Ankit Jain <[email protected]>

asimmahmood1 pushed a commit to jainankitk/OpenSearch that referenced this pull request


          Bump log4j2 from 2.21.0 to 2.25.1 (opensearch-project#19184)

db5cdfd

Signed-off-by: Andrey Pleskach <[email protected]>

pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request


          Bump log4j2 from 2.21.0 to 2.25.1 (opensearch-project#19184)

5747eb4

Signed-off-by: Andrey Pleskach <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

msfroh msfroh left review comments

cwperks cwperks approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

jed326 Awaiting requested review from jed326 jed326 is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

reta Awaiting requested review from reta reta is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

+1 more reviewer

navneet1v navneet1v left review comments

Labels

None yet