Skip to content

Remove unused "private" methods #19187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

Remove unused "private" methods #19187

merged 2 commits into from
Nov 4, 2025

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Aug 29, 2025

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

relates to:

@Pankraz76 Pankraz76 force-pushed the fix-S1144 branch 2 times, most recently from 6796693 to 0ecc72a Compare August 29, 2025 21:11
@Pankraz76 Pankraz76 marked this pull request as ready for review August 29, 2025 21:12
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

❌ Gradle check result for 0ecc72a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 3, 2025
Closed
Merged
@opensearch-trigger-bot
Copy link
Contributor

opensearch-trigger-bot bot commented Sep 29, 2025

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Sep 29, 2025
sandeshkr419
sandeshkr419 reviewed Nov 3, 2025
View reviewed changes
Copy link
Member

@sandeshkr419 sandeshkr419 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping remove the dead code. Looks good mostly, can you please remove changelog and rebase.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

❌ Gradle check result for 6c541f9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sandeshkr419 sandeshkr419 added skip-changelog and removed stalled Issues that have stalled labels Nov 3, 2025
@sandeshkr419 sandeshkr419 changed the title S1144: Unused "private" methods should be removed Remove unused "private" methods Nov 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

❌ Gradle check result for c161a3f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

❌ Gradle check result for c161a3f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

sandeshkr419
sandeshkr419 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI to go green!

@sandeshkr419 sandeshkr419 added the non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

✅ Gradle check result for c161a3f: SUCCESS

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.21%. Comparing base (db72ca2) to head (c161a3f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #19187      +/-   ##
============================================
+ Coverage     73.09%   73.21%   +0.12%     
- Complexity    71062    71175     +113     
============================================
  Files          5754     5754              
  Lines        325260   325194      -66     
  Branches      47036    47018      -18     
============================================
+ Hits         237736   238079     +343     
+ Misses        68383    67980     -403     
+ Partials      19141    19135       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandeshkr419 sandeshkr419 merged commit 6b5c08a into opensearch-project:main Nov 4, 2025
44 of 52 checks passed
@sandeshkr419
Copy link
Member

sandeshkr419 commented Nov 4, 2025

Thanks @Pankraz76 for working on this! Merged!

@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Nov 4, 2025

Thanks for catching up on this. @sandeshkr419

Without merge of maintainer any contribution seems obsolete.

This was referenced Nov 4, 2025
Open
Closed
Open
Merged
This was referenced Nov 7, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeshkr419 sandeshkr419 sandeshkr419 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@peternied peternied Awaiting requested review from peternied peternied is a code owner

Assignees

No one assigned

Labels

non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pankraz76 @sandeshkr419