Split up jvm.options for interoperability #19695
                
     Open
            
            
          
      
        
          +135
        
        
          −92
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
Make OpenSearch more container-friendly by splitting out default heap sizing from other, more specific JVM options.
This allows replacing or removing certain parts of the
jvm.optionswithout touching areas that are highly specific to OpenSearch (e.g. workarounds, logging and GC configuration).Example use case:
Vertically scaling a deployment on Kubernetes includes modifying
spec.containers[].resources.limits.memory, but that either leads to out-of-memory errors (OOMKilled) or the OpenSearch pod not making use of the additional memory, ifOPENSEARCH_JAVA_OPTSisn't modified in parallel.Making use of the JVM's container awareness (
-XX:+UseContainerSupport) to scale the heap dynamically isn't possible, due to static defaults injvm.options, which conflict with automatic heap sizing.While it's trivial to mount files (i.e.
heap.options) into the OpenSearch container at a certain location, one would rather not touch most parts of the configuration, thus this PR.Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.