Fix flaky PruneFileCacheIT #19710
Merged
Fix flaky PruneFileCacheIT #19710
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test seems to rely on a set of stats returned from some random node, which may differ from the node that processes the prune request. Ideally, by using the same client for each call, we'll have a more consistent view of the filed cache usage. Signed-off-by: Michael Froh <[email protected]>
msfroh
added
skip-changelog
flaky-test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19710 +/- ##
============================================
+ Coverage 73.08% 73.09% +0.01%
+ Complexity 70809 70795 -14
============================================
Files 5732 5732
Lines 324141 324141
Branches 46922 46922
============================================
+ Hits 236886 236925 +39
+ Misses 68182 68072 -110
- Partials 19073 19144 +71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test seems to rely on a set of stats returned from some random node, which may differ from the node that processes the prune request.
Ideally, by using the same client for each call, we'll have a more consistent view of the file cache usage.
I ran the test with 500 iterations after this fix and it passed every time.
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.