-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Make Lucene indexing and search work alongside parquet #20182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/datafusion
Are you sure you want to change the base?
Make Lucene indexing and search work alongside parquet #20182
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
❌ Gradle check result for 05152ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/shard/IndexShard.java
Outdated
Show resolved
Hide resolved
05152ad to
c9ef30b
Compare
Signed-off-by: expani <[email protected]>
Signed-off-by: expani <[email protected]>
|
❌ Gradle check result for 05dab3a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: expani <[email protected]>
|
Okay I was able to test Datafusion E2E locally and it's failing due to unmerged SQL plugin PR https://github.com/vinaykpud/sql/pull/21/files which uses the new index setting. Response The Lucene indices are getting created in a temp directory with prefix cc: @mch2 @bharath-techie |
|
❌ Gradle check result for bb7b681: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Added a new Index Setting called
index.optimized.enabledif true the index is created using the new IndexWriter plugin otherwise the existing Lucene index is created.SQL PR vinaykpud/sql#21