Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register alerts card with analytics workspace use case #1064

Conversation

amsiglan
Copy link
Collaborator

Description

This PR adds recent alerts card to the Overview page of Analytics (All) use case of workspaces.

image

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@ruanyl
Copy link
Member

ruanyl commented Sep 2, 2024

@amsiglan Your usage of content management plugin looks great to me!

riysaxen-amzn
riysaxen-amzn previously approved these changes Sep 3, 2024
AWSHurneyt
AWSHurneyt previously approved these changes Sep 3, 2024
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan dismissed stale reviews from AWSHurneyt and riysaxen-amzn via 074f80a September 3, 2024 19:26
@amsiglan
Copy link
Collaborator Author

amsiglan commented Sep 3, 2024

Screenshots for flaky tests:

image image

@amsiglan amsiglan merged commit 04119a5 into opensearch-project:main Sep 3, 2024
7 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
* added recent alerts card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed overflow in card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated badge text; fixed integ test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 04119a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 4, 2024
* added recent alerts card



* fixed overflow in card



* updated badge text; fixed integ test



---------


(cherry picked from commit 04119a5)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
* added recent alerts card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed overflow in card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated badge text; fixed integ test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 04119a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 4, 2024
* added recent alerts card



* fixed overflow in card



* updated badge text; fixed integ test



---------


(cherry picked from commit 04119a5)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Sep 19, 2024
…oject#1064)

* added recent alerts card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed overflow in card

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated badge text; fixed integ test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants