-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add langfuse blueprint #3418
base: main
Are you sure you want to change the base?
Add langfuse blueprint #3418
Conversation
Signed-off-by: Mingshi Liu <[email protected]>
|
||
## 2. Create Connector for Langfuse: | ||
The following connector is connecting to the API for getting a prompt. There are other apis from Langfuse that is available to connect to, please refer to https://api.reference.langfuse.com/#get-/api/public/comments. | ||
Note: The username:password should be Base64 encoded. The username is the Langfuse Public Key, and the password is the Langfuse Secret Key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make this a new line here since when we render it the sentence Note: ...
gets attached to the last sentence
Note: The username:password should be Base64 encoded. The username is the Langfuse Public Key, and the password is the Langfuse Secret Key. | |
The following connector is connecting to the API for getting a prompt. There are other apis from Langfuse that is available to connect to, please refer to https://api.reference.langfuse.com/#get-/api/public/comments. | |
Note: The username:password should be Base64 encoded. The username is the Langfuse Public Key, and the password is the Langfuse Secret Key. |
"description": "The connector to Langfuse", | ||
"protocol": "http", | ||
"parameters": { | ||
"promptName": "<YOUR_PROMPT_NAME>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This promptName gets used in the url but also in the payload? Must you use this same promptName consistently throughout all predictions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the promptName need a default value in the connectors in the url. This is a GET api, so the payload is not important. But I tried and we need something in the payload, that's why put the same promptName
} | ||
] | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a mini explanation of the inference result would be a bonus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I will try add some explanations
@@ -0,0 +1,167 @@ | |||
### Langfuse Connector Blueprint: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this makes sense to me but A little bit more context (in the beginning of the document) in the beginning would be great as a reader.
Description
Add langfuse blueprint to ml-commons documentation. Thanks @jngz-es for helping with the basic authentication configuration.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.