-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding code guidelines #502
base: main
Are you sure you want to change the base?
Adding code guidelines #502
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
============================================
- Coverage 81.72% 81.64% -0.09%
+ Complexity 2511 1253 -1258
============================================
Files 190 95 -95
Lines 8564 4282 -4282
Branches 1436 718 -718
============================================
- Hits 6999 3496 -3503
+ Misses 1010 507 -503
+ Partials 555 279 -276 ☔ View full report in Codecov by Sentry. |
@martin-gaievski Can we update table of contents on dev guide as well? |
Hi @martin-gaievski ! Are you still taking care of this PR? Why this is still draft? |
ff18ce6
to
d693b58
Compare
@yuye-aws resumed work on this PR, feel free to leave comments |
509cb24
to
71d31e6
Compare
@martin-gaievski Can we resurrect this PR ? |
71d31e6
to
eccf8b1
Compare
yup, we can for sure, rebased it on latest main |
BWC are failing, looks like ml-commons related problem:
|
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
eccf8b1
to
14ff4f4
Compare
Description
There are no code guidelines for the repo, this slows down new contributors and add cycles during code reviews.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.