[Manual Backport] Update tests failing against react 18 to react-testing-library (#1632) #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-project#1632) Signed-off-by: Viraj Sanghvi <[email protected]> (cherry picked from commit fd97744) Signed-off-by: Viraj Sanghvi <[email protected]>
virajsanghvi
force-pushed
the
backport/backport-1632-to-1.x
branch
from
0664f5f to
71de7e5
Compare
* Make SplitButton display simple button when no options Signed-off-by: Peter Fitzgibbons <[email protected]> * Changelog Fix Split Button Signed-off-by: Peter Fitzgibbons <[email protected]> * Remove hairline if simple-button displayed Signed-off-by: Peter Fitzgibbons <[email protected]> --------- Signed-off-by: Peter Fitzgibbons <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> (cherry picked from commit bae0acb)
virajsanghvi
requested review from
AMoo-Miki,
Maosaic,
angle943,
ashwin-pc,
d-buckner,
ruanyl and
ruchidh
as code owners
ruchidh
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #1632 to 1.x (cherry picked from commit fd97744)
Also backports #1209 to 1.x (cherry-picked from bae0acb) as that was not backported last year
Description
N/A
Issues Resolved
N/A
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.