Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenSAML to 5.1.3 #5038

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

willyborankin
Copy link
Collaborator

Description

Bump OpenSAML to 5.1.3

Check List

  • New functionality includes testing
  • New functionality has been documented
  • New Roles/Permissions have a corresponding security dashboards plugin PR
  • API changes companion pull request created
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (e120f71) to head (cf11e5f).

Files with missing lines Patch % Lines
.../dlic/auth/http/saml/SamlHTTPMetadataResolver.java 50.00% 2 Missing ⚠️
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% 1 Missing ⚠️
...azon/dlic/util/SettingsBasedSSLConfiguratorV4.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5038      +/-   ##
==========================================
+ Coverage   71.43%   71.53%   +0.09%     
==========================================
  Files         336      336              
  Lines       22617    22617              
  Branches     3599     3599              
==========================================
+ Hits        16157    16178      +21     
+ Misses       4660     4640      -20     
+ Partials     1800     1799       -1     
Files with missing lines Coverage Δ
...zon/dlic/auth/http/saml/HTTPSamlAuthenticator.java 67.51% <100.00%> (ø)
...zon/dlic/auth/http/saml/Saml2SettingsProvider.java 60.18% <ø> (ø)
...rity/opensaml/integration/SecurityX509CRLImpl.java 0.00% <ø> (ø)
...nsaml/integration/SecurityX509CertificateImpl.java 76.19% <ø> (ø)
...egration/SecurityXMLObjectProviderInitializer.java 74.19% <ø> (ø)
...auth/http/saml/SamlFilesystemMetadataResolver.java 0.00% <0.00%> (ø)
...azon/dlic/util/SettingsBasedSSLConfiguratorV4.java 58.58% <0.00%> (-0.30%) ⬇️
.../dlic/auth/http/saml/SamlHTTPMetadataResolver.java 57.69% <50.00%> (-3.85%) ⬇️

... and 6 files with indirect coverage changes

reta
reta previously approved these changes Jan 18, 2025
RyanL1997
RyanL1997 previously approved these changes Jan 19, 2025
Signed-off-by: Andrey Pleskach <[email protected]>
@cwperks cwperks merged commit 34735bb into opensearch-project:main Jan 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants