Ensure that IndexResolverReplacer resolves to indices for RolloverRequests #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able IndicesRequests Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
DarshitChanpura,
derek-ho,
nibix,
peternied,
RyanL1997,
reta and
willyborankin
as code owners
Signed-off-by: Craig Perkins <[email protected]>
cwperks
changed the title
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5076 +/- ##
==========================================
+ Coverage 71.48% 71.51% +0.02%
==========================================
Files 336 336
Lines 22625 22628 +3
Branches 3601 3602 +1
==========================================
+ Hits 16174 16182 +8
+ Misses 4651 4644 -7
- Partials 1800 1802 +2
|
Signed-off-by: Craig Perkins <[email protected]>
nibix
reviewed
Feb 3, 2025
src/main/java/org/opensearch/security/resolver/IndexResolverReplacer.java
Show resolved
Hide resolved
nibix
reviewed
Feb 3, 2025
src/main/java/org/opensearch/security/resolver/IndexResolverReplacer.java
Show resolved
Hide resolved
Signed-off-by: Craig Perkins <[email protected]>
RyanL1997
approved these changes
Feb 4, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…uests (#5076) Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 0326d7a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered this issue while trying to adapt ISM to the replacement for ThreadContext.stashContext. I noticed that the security plugin was failing to resolve indices for RolloverRequests and the reason for that is that RolloverRequest is an IndicesRequest, but it does not also implement the IndicesRequest.Replaceable interface that is already handled in IndexResolverReplacer.
Bug fix
Testing
Currently working on a test to replicate the problem
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.