Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.19] Update restPathMatches to handle case with missing leading slash (#5061) #5077

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 31, 2025

Backport #5061 to 2.19

…pensearch-project#5061)

Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 772eef6)
derek-ho
derek-ho previously approved these changes Jan 31, 2025
RyanL1997
RyanL1997 previously approved these changes Jan 31, 2025
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks dismissed stale reviews from RyanL1997 and derek-ho via e1efbe5 February 1, 2025 00:29
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (c50a90e) to head (e1efbe5).
Report is 1 commits behind head on 2.19.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             2.19    #5077      +/-   ##
==========================================
- Coverage   68.14%   68.08%   -0.06%     
==========================================
  Files         347      347              
  Lines       24550    24552       +2     
  Branches     4069     4070       +1     
==========================================
- Hits        16730    16717      -13     
- Misses       5897     5913      +16     
+ Partials     1923     1922       -1     
Files with missing lines Coverage Δ
...opensearch/security/filter/SecurityRestFilter.java 84.32% <100.00%> (+0.23%) ⬆️

... and 5 files with indirect coverage changes

@cwperks cwperks merged commit 1d4f54e into opensearch-project:2.19 Feb 1, 2025
80 of 81 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 1, 2025
…leading slash (#5061) (#5077)

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 1d4f54e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants