Add Shikhar Jain (GH: shikharj05) as a maintainer#5252
Merged
cwperks merged 1 commit intoopensearch-project:mainfrom Apr 8, 2025
Merged
Add Shikhar Jain (GH: shikharj05) as a maintainer#5252cwperks merged 1 commit intoopensearch-project:mainfrom
cwperks merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <[email protected]>
reta
approved these changes
Apr 8, 2025
willyborankin
approved these changes
Apr 8, 2025
peternied
approved these changes
Apr 8, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5252 +/- ##
==========================================
- Coverage 71.72% 71.69% -0.03%
==========================================
Files 335 335
Lines 22742 22742
Branches 3597 3597
==========================================
- Hits 16312 16306 -6
- Misses 4638 4644 +6
Partials 1792 1792 🚀 New features to boost your workflow:
|
nibix
approved these changes
Apr 8, 2025
RyanL1997
approved these changes
Apr 8, 2025
peterzhuamazon
approved these changes
Apr 8, 2025
DarshitChanpura
pushed a commit
to DarshitChanpura/security
that referenced
this pull request
Apr 21, 2025
…#5252) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have nominated and maintainers have agreed to add @shikharj05 as a co-maintainer of the security repo.
@shikharj05 has made many valuable contributions and given insightful comments on reviews and GH issues over the last few years.
Shikhar is an avid PR reviewer and has reviewed a total of 127 PRs (including open and closed) - a great quality of a maintainer :).
See all PRs where Shikhar has engaged as a commenter: https://github.com/opensearch-project/security/pulls?q=is%3Apr+commenter%3Ashikharj05
Some notable PR reviews include:
Shikhar also routinely opens up issues on the Security repo with valuable feature requests and reports of deficiencies (8 in total):
Shikhar's first issue opened was in May 2022. Notable issue submissions include:
Shikhar regularly contributes to conversation on Github issues (including RFCs):
See all issues where Shikhar has engaged as a commenter: https://github.com/opensearch-project/security/issues?q=is%3Aissue+commenter%3Ashikharj05
Shikhar has 12 contributions on main and has additional changes open for review as well. Here are some highlights:
See all code contributions (Open + Closed) from Shikhar here: https://github.com/opensearch-project/security/commits?author=shikharj05
Additionally, Shikhar is active in the community and has given a talk at OpenSearch Con SF on attribute-based access control (ABAC):https://www.youtube.com/watch?v=zB4Mnue8mi0