You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
This PR adds a minimal multi-stage Dockerfile to provide a consistent containerized environment for building and testing the project. It helps streamline local development, CI integration, and onboarding by encapsulating dependencies. It is also helpful for running the software locally quickly.
Documentation:
I think it would be helpful to add documentation on how to run this quickly. I am just not sure if you all would want that in the README, the Developer Guide, or in a separate markdown file. Happy to add that if you all point me in the right direction.
This is great, but the default OSGi bundle repo in dist/osgi/config.json is quite outdated, and developers often use the osh-node-dev-template project for testing core, addon, and build changes together. Would you be able to create a similar Dockerfile for osh-addons, and a docker-compose.yml for osh-node-dev-template? Then we could test containerized environments of the individual repos (osh-addons & osh-core), as well as the two working together.
It would be great to have an easy way to set up both an OSGi bundle repository server (with osh-addons) and OSH server (osh-core), with the local bundle server linked to the local OSH node.
We can also work on adding this documentation for containerized deployments/testing in the osh-docs repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a minimal multi-stage Dockerfile to provide a consistent containerized environment for building and testing the project. It helps streamline local development, CI integration, and onboarding by encapsulating dependencies. It is also helpful for running the software locally quickly.
Documentation:
I think it would be helpful to add documentation on how to run this quickly. I am just not sure if you all would want that in the README, the Developer Guide, or in a separate markdown file. Happy to add that if you all point me in the right direction.