Make CSAPI thread pool size configurable#328
Merged
alexrobin merged 4 commits intoopensensorhub:masterfrom Jan 8, 2026
Merged
Conversation
Member
|
Did increasing the pool size help with your issue in the end? |
alexrobin
reviewed
Jan 7, 2026
|
|
||
|
|
||
| @DisplayInfo(label="Thread Pool Size", desc="Number of threads used by the service to handle incoming requests") | ||
| public int threadPoolSize = Runtime.getRuntime().availableProcessors(); |
Member
There was a problem hiding this comment.
Maybe it would be better to default to the number of available processors when this is set to a special value (like 0) instead of setting it directly in the config (+ update the desc annotation to document this)
…mber of processors in CSAPI service module
Author
|
I believe it should work a lot better in an upcoming event in which we need to ingest a lot of video streams. I don't currently have the time to implement the "distributed" obs store (with multiple MV store), but will also work toward that change. Also, I have made the change to keep the config file clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small configuration change that allows for higher thread pool size of CSAPI service, to better handle large amounts of transactions. We are allowed to configure this to be higher because CSAPI request handling is almost entirely I/O bound.