Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.13] Drop uid and guid in 3scale-kourier-gateway #127

Merged

Conversation

ReToCode
Copy link

@ReToCode ReToCode commented Mar 1, 2024

Changes

/assign @skonto

I'll do a manual port to main if openshift-knative/serverless-operator#2524 works.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-v1.13@8a981e6). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-v1.13     #127   +/-   ##
================================================
  Coverage                 ?   60.63%           
================================================
  Files                    ?       24           
  Lines                    ?     2002           
  Branches                 ?        0           
================================================
  Hits                     ?     1214           
  Misses                   ?      726           
  Partials                 ?       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link

skonto commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f20d9c6 into openshift-knative:release-v1.13 Mar 1, 2024
16 checks passed
@ReToCode ReToCode changed the title Drop uid and guid in 3scale-kourier-gateway [RELEASE-1.13] Drop uid and guid in 3scale-kourier-gateway Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants