Skip to content
This repository has been archived by the owner on Sep 4, 2023. It is now read-only.

Commit

Permalink
Print error in knativeServingDelete (knative#268)
Browse files Browse the repository at this point in the history
This makes a tiny change that knativeServingDelete prints missing error message.

Currently the error prints as:

```
    --- FAIL: TestKnativeServingDeployment/delete (30.65s)
        knativeservingdeployment_test.go:244: The CustomResourceDefinition ingresses.networking.internal.knative.dev failed to be deleted
```

and it is difficult to find the reason why `clients.Dynamic.Resource(gvrs).Get()` failed to delete.
  • Loading branch information
nak3 authored and knative-prow-robot committed Jan 28, 2020
1 parent 4f0f0fb commit 331df80
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/knativeservingdeployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func knativeServingDelete(t *testing.T, clients *test.Clients, names test.Resour
}
gvrs, _ := meta.UnsafeGuessKindToResource(u.GroupVersionKind())
if _, err := clients.Dynamic.Resource(gvrs).Get(u.GetName(), metav1.GetOptions{}); !apierrs.IsNotFound(err) {
t.Fatalf("The %s %s failed to be deleted", u.GetKind(), u.GetName())
t.Fatalf("The %s %s failed to be deleted: %v", u.GetKind(), u.GetName(), err)
}
}
}
Expand Down

0 comments on commit 331df80

Please sign in to comment.