Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.15] Remove "DELETE" from the Serving validating webhook #1103

Open
wants to merge 2 commits into
base: release-v1.15
Choose a base branch
from

Conversation

skonto
Copy link

@skonto skonto commented Jan 27, 2025

  • See discussion here
  • This has been kept upstream for compatibility reasons but could cause issues during deletion.
  • We want to avoid a scenario where due to foreground deletion the webhook deployment is removed before a certificate resource is deleted e.g. routing-serving-certs.

@openshift-ci openshift-ci bot requested review from mgencur and mvinkler January 27, 2025 12:18
@skonto
Copy link
Author

skonto commented Jan 27, 2025

/assign @rhuss @dsimansk

@skonto
Copy link
Author

skonto commented Jan 27, 2025

/cherry-pick release-v1.16
/cherry-pick release-v1.17

@openshift-cherrypick-robot

@skonto: once the present PR merges, I will cherry-pick it on top of release-v1.16, release-v1.17 in new PRs and assign them to you.

In response to this:

/cherry-pick release-v1.16
/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto skonto changed the title [RELEASE-1.15] Remove "DELETE" from serving validating webhook [RELEASE-1.15] Remove "DELETE" from the Serving validating webhook Jan 27, 2025
@skonto
Copy link
Author

skonto commented Jan 27, 2025

Using token for quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-serving-load-test
Error: unexpected EOF

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
Command exited with non-zero status 2

@skonto
Copy link
Author

skonto commented Jan 27, 2025

/retest ?

Copy link

openshift-ci bot commented Jan 27, 2025

@skonto: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test 413-images
/test 413-test-e2e
/test 413-test-e2e-tls
/test 417-images
/test 417-test-e2e
/test 417-test-e2e-tls

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serving-release-v1.15-417-images
pull-ci-openshift-knative-serving-release-v1.15-417-test-e2e
pull-ci-openshift-knative-serving-release-v1.15-417-test-e2e-tls

In response to this:

/retest ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Jan 27, 2025

/retest

@dsimansk
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Author

skonto commented Jan 28, 2025

/override ?

Copy link

openshift-ci bot commented Jan 28, 2025

@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ?

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / kn-serving-test-hellohttp2-115-on-pull-request
  • Red Hat Konflux / kn-serving-test-helloworld-115-on-pull-request
  • Red Hat Konflux / kn-serving-test-timeout-115-on-pull-request
  • ci/prow/417-images
  • ci/prow/417-test-e2e
  • ci/prow/417-test-e2e-tls
  • pull-ci-openshift-knative-serving-release-next-417-images
  • pull-ci-openshift-knative-serving-release-next-417-test-e2e
  • pull-ci-openshift-knative-serving-release-v1.15-417-test-e2e-tls
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Author

skonto commented Jan 28, 2025

/override "Red Hat Konflux / kn-serving-test-hellohttp2-115-on-pull-request"
/override "Red Hat Konflux / kn-serving-test-helloworld-115-on-pull-request"
/override "Red Hat Konflux / kn-serving-test-timeout-115-on-pull-request"

/hold for testing at the S-O side first.

Copy link

openshift-ci bot commented Jan 28, 2025

@skonto: Overrode contexts on behalf of skonto: Red Hat Konflux / kn-serving-test-hellohttp2-115-on-pull-request, Red Hat Konflux / kn-serving-test-helloworld-115-on-pull-request, Red Hat Konflux / kn-serving-test-timeout-115-on-pull-request

In response to this:

/override "Red Hat Konflux / kn-serving-test-hellohttp2-115-on-pull-request"
/override "Red Hat Konflux / kn-serving-test-helloworld-115-on-pull-request"
/override "Red Hat Konflux / kn-serving-test-timeout-115-on-pull-request"

/hold for testing at the S-O side first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants