AGENT-1193: Custom openshift-install to generate unconfigued-ign #122
Conversation
The openshift appliance build command has a flag called --debug-base-ignition when provided, allows using a custom openshift-install binary to generate the unconfigured-ignition instead of the binary downloaded from the release. When the flag is provided, openshift appliance looks for the custom openshift-install binary in its assets directory. The build script has been updated to detect if a custom openshift-install binary has been provided in the assets directory and if present, adds the --debug-base-ignition flag. One use case would be for dev-scripts. When the configuration variable KNI_INSTALL_FROM_GIT is set to true, dev-scripts builds the openshift-install binary from source and uses it to generate the agent ISO. We would like the appliance to also use the same openshift-install binary that was generated from source to build its images. A supporting PR in dev-scripts will copy the openshift-install binary to the appliance's asset directory when KNI_INSTALL_FROM_GIT=true. In combination with this PR, it will activate the --debug-base-ignition flag.
|
@rwsu: This pull request references AGENT-1193 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@rwsu: This pull request references AGENT-1193 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rwsu: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think there was this one pending from @pawanpinjarkar , and addressing the same topic? #82 |
Yes, I missed that one and it is doing essentially the same thing. I tried to keep modifications like https://github.com/openshift/agent-installer-utils/pull/82/files#diff-ba34810993944bbb8587a9487c6e5f24fd8c8723a093f8f1be5708eb0953a294R158 within dev-scripts, so that we don't need to copy the code that patches the release version into this repo. I think having the environment variable like CUSTOM_OPENSHIFT_INSTALLER_PATH as in #82 or a command line flag would beneficial. My patch assumes the binary is copied in a certain location in order for it to add the --debug-base-ignition flag. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
5 participants
The openshift appliance build command has a flag called
--debug-base-ignition
when provided, allows using a custom openshift-install binary to generate the unconfigured-ignition instead of the binary downloaded from the release.
When the flag is provided, openshift appliance looks for the custom openshift-install binary in its assets directory.
The build script has been updated to detect if a custom openshift-install binary has been provided in the assets directory and if present, adds the --debug-base-ignition flag.
One use case would be for dev-scripts. When the configuration variable KNI_INSTALL_FROM_GIT is set to true, dev-scripts builds the openshift-install binary from source and uses it to generate the agent ISO. We would like the appliance to also use the same openshift-install binary that was generated from source to build its images. A supporting PR in dev-scripts will copy the openshift-install binary to the appliance's asset directory when KNI_INSTALL_FROM_GIT=true. In combination with this PR, it will activate the --debug-base-ignition flag.
Works in conjunction with: openshift-metal3/dev-scripts#1775